> -----Original Message-----
> From: Kalle Valo <kvalo@xxxxxxxxxx>
> Sent: Thursday, January 11, 2024 7:13 PM
> To: Lingbo Kong (QUIC) <quic_lingbok@xxxxxxxxxxx>
> Cc: ath12k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3] wifi: ath12k: report tx bitrate for iw dev xxx station
> dump
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> Lingbo Kong <quic_lingbok@xxxxxxxxxxx> writes:
>
> > The tx bitrate of "iw dev xxx station dump" always show an invalid
> > value "tx bitrate: 6.0MBit/s".
> >
> > To address this issue, parse the tx complete report from firmware and
> > indicate the tx rate to mac80211.
> >
> > After that, "iw dev xxx station dump" show the correct tx bitrate such as:
> > tx bitrate: 104.0 MBit/s MCS 13
> > tx bitrate: 144.4 MBit/s MCS 15 short GI tx bitrate: 626.9 MBit/s
> > 80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 tx bitrate: 1921.5 MBit/s
> > 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0
> >
> > Tested-on: WCN7850 hw2.0 PCI
> > WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
> >
> > Signed-off-by: Lingbo Kong <quic_lingbok@xxxxxxxxxxx>
>
> [...]
>
> > +static void ath12k_dp_tx_update(struct ath12k *ar, struct
> > +hal_tx_status *ts) {
> > + if (!ar->ab->hw_params->single_pdev_only)
> > + return;
>
> I'm not really a fan of using single_pdev_only to check for other features.
> Basically what this check implies is if we are using a mobile chipset or not,
> right?
>
> I can't test QCN9274 right now but why do we need this check? I would hope
> that the firmware interface is designed so that this check is not needed.
>
Hi kalle,
You're right, Ramasamy Kaliappan help me test this patch on QCN9274.
I'll send you a new version of this patch.
Best regards,
Lingbo Kong
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
> ches
