On Thu, 2024-02-01 at 10:21 -0800, Jeff Johnson wrote: > > > + > > + TP_fast_assign( > > + LOCAL_ASSIGN; > > + VIF_ASSIGN; > > + __entry->link_id = > > + ieee80211_vif_is_mld(&sdata->vif) ? link->link_id : -1; > > why go to this trouble? > why not just print the link_id that was passed into > ieee80211_request_smps()? just so non-MLD will give -1 instead of 0? > seems all of the other existing trace functions just print the link_id > that was provided Yeah, good point, we should anyway know from the context whether it's MLO or not. Didn't really think about it, tbh. johannes
