On Mon, 2024-01-29 at 19:51 +0100, Johannes Berg wrote: > On Mon, 2024-01-29 at 19:34 +0100, Johannes Berg wrote: > > > > As part of the refactoring to more clearly determine both local > > and AP mode (HT/VHT/HE/EHT) and channel configuration, this makes > > mac80211 a bit more strict: > > - no longer accept channel switch when the mode changes > > - no longer use e.g. VHT if the HT channel inside of it > > occupies the wrong spot (e.g. center 40 MHz inside 80 MHz) > > - don't use EHT with bad puncturing (punctured subchannels > > cover subchannels that are used by HE) > > > > Hopefully these things won't really break anything outside of > > a handful of hostapd tests seem misconfigured (e.g > > > > Err, sorry. > > The tests that are broken are mostly because of the first bullet, and we > had fixed this by: > https://lists.infradead.org/pipermail/hostap/2023-December/042218.html > but (IMHO) the justification was bad - I'd still think it's weird to > switch off e.g. EHT completely during CSA, and certainly mac80211 makes > no attempt at tracking this and reacting to it (e.g. updating rate > control to disable EHT rates), which is why I did the change to not > accept it, and disconnect (which should lead to reconnect). > > The EHT puncturing tests are broken because of the last bullet, and I > had fixed that in a patch I just sent to the list, https://lists.infradead.org/pipermail/hostap/2024-January/042316.html johannes