Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 1/22/2024 6:56 PM, Baochen Qiang wrote: >> In ath11k_mac_op_assign_vif_chanctx(), there is a logic to >> create peer using ar->mac_addr for a STA vdev. This is invalid >> because a STA vdev should have a peer created using AP's >> MAC address. Besides, if we run into that logic, it means a peer >> has already been created earlier, we should not create it again. >> So remove it. >> >> This is found during code review. >> >> Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 >> Tested-on: WCN6855 hw2.1 PCI >> WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 >> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 >> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> >> --- >> drivers/net/wireless/ath/ath11k/mac.c | 16 ---------------- > > My Qualcomm Innovation Center copyright checker reports: > drivers/net/wireless/ath/ath11k/mac.c copyright missing 2024 > > Kalle can fix this in the pending branch Thanks, I added 2024. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches