On 1/25/24 05:10, Jeff Johnson wrote:
On 1/24/2024 5:28 AM, Aditya Kumar Singh wrote:
Currently whenever NL80211_CMD_DEL_STATION command is called without any
MAC address, all stations present on that interface are flushed.
However with MLO there is a need to flush the stations from a particular
link in the interface, and not from all the links associated with the MLD
interface.
For example - 2 GHz and 5 GHz are part of an AP MLD. When 2 GHz BSS is
brought up, it sends flush command on the interface (MLD). Then eventually
"it sends": can you please clarify what "it" is
Hostapd. During any BSS bring up, it sends NL80211_CMD_DEL_STATION
without any mac address (since at that point expectation is to delete
any stale station entries on that interface). But now with MLO, need is
there to handle this on link basis.
5 GHZ links comes up and that also sends the command on the same interface.
"that also sends": likewise what is "that"
Same hostapd.
Now by the time 5 GHz link comes up, if any station gets connected to 2 GHz
link, it would be flushed while 5 GHz link is started which is wrong.
Hence, add an option to pass link ID as well in the command so that if link
ID is passed, station using that passed link ID alone would be deleted
and others will not be removed.
A subsequent patch would add logic to delete only the station using the
passed link ID.
Signed-off-by: Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx>
Actual code change LGTM
Even though the current example is hostapd but the use case is at any
time and by any user space application. If there is need to flush all
stations (from a link), just sending NL80211_CMD_DEL_STATION would not
work in case of MLO.
