Sriram R <quic_srirrama@xxxxxxxxxxx> wrote: > Currently, the logic used to select the 6 GHz band is incorrect, > which may cause 6 GHz supported channels to not be updated properly. > This is because the 6 GHz Max frequency supported by the driver is > being compared to the Max frequency supported on the board. If in > some cases, the 6 GHz Max frequency supported on the board is less > than the defined 6 GHz Max frequency, all 6 GHz channels are disabled. > To address this, compare the max frequency supported by the board to > the defined 6 GHz Minimum frequency by the driver. > > Similarly, when a dual mac card supports both 6 GHz and 5 GHz radios, > if the 5 GHz radio gets enumerated first before 6 GHz, the checks in > ath12k_mac_setup_channels_rates() can cause the 5 GHz channels which > were enabled earlier to get disabled when the 6 GHz channel list is > updated. This is because the Min 6 GHz frequency defined in the driver > is 5945 MHz, which should be 5925 MHz since channel 2 is not considered > currently, but the firmware can pass 5925 MHz as the minimum. > Hence, update the Min frequency supported by the driver to 5925 MHz. > > In addition, ensure that the channel list update to firmware updates > only the channels that the current radio (ar) supports rather than > considering the wiphy support. This would be required when multiple pdevs > are supported in a wiphy and they support different ranges of frequencies > or bands as in single wiphy support. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Sriram R <quic_srirrama@xxxxxxxxxxx> > Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 67a48d937fac wifi: ath12k: Fix issues in channel list update -- https://patchwork.kernel.org/project/linux-wireless/patch/20240117062628.8260-1-quic_srirrama@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches