Re: [PATCH 2/2] [v3] wifi: brcmfmac: handle possible PCIE irq handling errors

[Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx>]

On January 24, 2024 7:22:58 AM Dmitry Antipov <dmantipov@xxxxxxxxx> wrote:

> On 1/22/24 21:20, Bjorn Helgaas wrote:
>
> > If you have occasion to update this, possibly s/PCIE/PCI/ in the
> > subject, since this is generic to PCI and PCIe.
>
> OK. BTW if we're touching this anyway, shouldn't we hook into the generic 
> device
> framework and switch to devm_request_threaded_irq()/devm_free_irq() as well?

Hi Dmitry,

Those are not generic device functions. They create device managed resource 
so devm_free_irq() is implicitly invoked upon device detach. So replacing 
free_irq() with devm_free_irq() is not very meaningful. There are some 
devm_*() usages in the driver, but it's not used commonly. However, feel 
free to add it.

Regards,
Arend

> Dmitry

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature