On Tue, Jan 23, 2024 at 3:22 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote: > Not sure what happened with git send-email, but most of the commit message seems to have disappeared. This should have included the following: ``` Calling spi_sync() unconditionally sets the spi field of struct spi_message. Therefore setting msg.spi = spi before calling spi_sync() has no effect and can be removed. ``` I can resend if there are no further comments. > (spi_message_add_tail() does not access this field.) > > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx> > --- > drivers/net/wireless/microchip/wilc1000/spi.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c > index 77b4cdff73c3..7eb0f8a421a3 100644 > --- a/drivers/net/wireless/microchip/wilc1000/spi.c > +++ b/drivers/net/wireless/microchip/wilc1000/spi.c > @@ -300,7 +300,6 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len) > > memset(&msg, 0, sizeof(msg)); > spi_message_init(&msg); > - msg.spi = spi; > spi_message_add_tail(&tr, &msg); > > ret = spi_sync(spi, &msg); > @@ -343,7 +342,6 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen) > > memset(&msg, 0, sizeof(msg)); > spi_message_init(&msg); > - msg.spi = spi; > spi_message_add_tail(&tr, &msg); > > ret = spi_sync(spi, &msg); > @@ -381,8 +379,6 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen) > > memset(&msg, 0, sizeof(msg)); > spi_message_init(&msg); > - msg.spi = spi; > - > spi_message_add_tail(&tr, &msg); > ret = spi_sync(spi, &msg); > if (ret < 0) > -- > 2.43.0 >
