Erick Archer <erick.archer@xxxxxxx> wrote: > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or similar) > function arguments due to the risk of them overflowing. This could lead > to values wrapping around and a smaller allocation being made than the > caller was expecting. Using those allocations could lead to linear > overflows of heap memory and other misbehaviors. > > So, use the purpose specific kcalloc() function instead of the argument > size * count in the kzalloc() function. > > Also, it is preferred to use sizeof(*pointer) instead of sizeof(type) > due to the type of the variable can change and one needs not change the > former (unlike the latter). > > Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] > Link: https://github.com/KSPP/linux/issues/162 > Signed-off-by: Erick Archer <erick.archer@xxxxxxx> > Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > Acked-by: Stanislaw Gruszka <stf_xl@xxxxx> Patch applied to wireless-next.git, thanks. acf868ff60b1 wifi: iwlegacy: Use kcalloc() instead of kzalloc() -- https://patchwork.kernel.org/project/linux-wireless/patch/20240119171655.7740-1-erick.archer@xxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
