Search Linux Wireless

Re: [PATCH] wifi: mwifiex: cleanup SSID-related data types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Antipov <dmantipov@xxxxxxxxx> wrote:

> Drop unused 'struct mwifiex_ssid_bssid' and replace custom
> 'struct mwifiex_802_11_ssid' with generic 'struct cfg80211_ssid'
> as a member of 'struct mwifiex_uap_bss_param'. Compile tested only.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>

The commit message should also explain _why_ this change is safe. I have
no idea if you just randomly changed this or there was a proper
analysis. For example, there are changes in length field and if the
firmware uses this struct there will be problems.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240118145715.475513-1-dmantipov@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux