Dmitry Antipov <dmantipov@xxxxxxxxx> wrote: > Drop unused 'struct mwifiex_ssid_bssid' and replace custom > 'struct mwifiex_802_11_ssid' with generic 'struct cfg80211_ssid' > as a member of 'struct mwifiex_uap_bss_param'. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx> The commit message should also explain _why_ this change is safe. I have no idea if you just randomly changed this or there was a proper analysis. For example, there are changes in length field and if the firmware uses this struct there will be problems. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20240118145715.475513-1-dmantipov@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches