Dmitry Antipov <dmantipov@xxxxxxxxx> wrote: > In 'brcmf_chip_recognition()', always check the value returned by > 'brcmf_chip_add_core()' with 'IS_ERR()' and return convenient > 'PTR_ERR()' in case of error. > > Fixes: cb7cf7be9eba ("brcmfmac: make chip related functions host interface independent") > Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx> This should be tested on a real device. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230821112337.160974-1-dmantipov@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches