On Fri, Jan 12, 2024 at 3:43 AM Lukas Wunner <lukas@xxxxxxxxx> wrote: > > On Thu, Jan 11, 2024 at 05:16:45PM +0100, Bartosz Golaszewski wrote: > > On Thu, Jan 11, 2024 at 4:02???PM Lukas Wunner <lukas@xxxxxxxxx> wrote: > > > On Wed, Jan 10, 2024 at 05:26:52PM +0100, Bartosz Golaszewski wrote: > > > > if (pci_is_bridge(dev)) > > > > of_pci_make_dev_node(dev); > > > > > > But perhaps of_pci_make_dev_node() returns immediately because: > > > > No, it was actually a no-op due to CONFIG_PCI_DYNAMIC_OF_NODES not > > being set. But this is only available if CONFIG_OF_DYNAMIC is enabled > > which requires OF_UNITTEST (!). > > > > We definitely don't need to enable dynamic OF nodes. We don't want to > > modify the DT, we want to create devices for existing nodes. > > Consider refactoring of_pci_make_dev_node() to suit your needs or > add a separate function call inside the "if (pci_is_bridge(dev))" > clause which populates the child OF nodes. The latter because of_pci_make_dev_node() has absolutely nothing to do with the issue this series solves. The uses are pretty much mutually exclusive. If we have a DT node with power related properties, there is no need to create that node because it already exists. Rob
