Search Linux Wireless

Re: [PATCH] wifi: rtl8xxxu: add missing number of sec cam entries for all variants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kalle,

Am 16.01.24 um 12:13 schrieb Kalle Valo:
Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> writes:

Commit b837f78fbffa ("wifi: rtl8xxxu: add hw crypto support for AP
mode") introduced max_sec_cam_num as a member of rtl8xxxu_fileops.
It was missed to set this number for all variants except 8188f, which
caused rtl8xxxu_get_free_sec_cam() to always return 0.

Fix it by adding the numbers for all variants. The values are taken from
the vendor drivers and rtlwifi.

Does this fix a user visible regression? It would be good to add that to
the commit message. I can do it, just let me know what to add.


Yes, traffic to encrypted networks was broken for all hw variants except 8188f. This was reported by Zenm Chen in [1].

Maybe you could add something like:
[..]
caused rtl8xxxu_get_free_sec_cam() to always return 0 and therefore breaking encrypted traffic.

[1] https://lore.kernel.org/linux-wireless/20240111163603.2325-1-zenmchen@xxxxxxxxx/




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux