On Wed, Nov 26, 2008 at 03:02:58PM +0100, Johannes Berg wrote: > When a station goes to PS mode to scan, it will then send > probe requests without the PS bit set. mac80211 will take > that as indication that the station woke up, but it didn't. > This patch changes mac80211 to only consider doze->wake > transitions on data frames to to fix that issue. IEEE Std 802.11-2007 is indeed quite unclear on number of power save related topics. This is being worked on in IEEE 802.11 TGmb, but well, nothing final from that is going to come out for years, so we better follow common sense here. It looks like this change is the best option we have for processing doze->wake transition. The standard actually has text that mandates that management frames shall not have Power Management field set to one and as such, the STA sending Probe Request frames does need to remain awake to receive the Probe Response, but if it also happens to be associated at the same time, the AP that it is associated with should probably not think that the STA is going to remain awake after having received the Probe Response frame. This patch seems to take care of this corner case. Based on what happens with the discussions at TGmb, this area may need to be changed again. For example, I could think of Action frames being handled like Data frames here, but well, that can happen once we get some more thought out comments about proposed changes to the standard. -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html