On 1/15/2024 8:57 PM, Kalle Valo wrote:
Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> writes:
Is there a reason why you moved these two functions from mac.c to
core.c? This is mac level code anyway, right?
This is not fully mac level code, some parts of SoC/chip level code
bindup in the mac level. So i segregated the SoC level code like ab
related param initialization handling from the mac level procedure.
Now, mac/radio should take care only radio level handling procedure.
In future for MLO, SoC level can be extend easily.
But is there a concrete reason to have the functions in core.c? In your
following patches I couldn't see why to move these functions to core.c,
everything seems to be suitable for mac.c.
I experimented this in the pending branch and moved the functions to
mac.c (tag ath-pending-202401151424):
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=bee89ac2b5755754849deaf7054828e982cc6658
I also fixed your other patchsets to match that and to me it makes more
sense to have everything in mac.c. I prefer to make core.c as simple as possible.
As you can see I also made changes to the patch titles to make them more
understandable:
wifi: ath12k: refactor ath12k_mac_register() and ath12k_mac_unregister()
Thoughts?
Looks fine to me.
Thanks,
Karthikeyan
