> -----Original Message----- > From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Sent: Saturday, January 13, 2024 7:42 AM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Subject: [PATCH] wifi: rtlwifi: rtl8192de: Don't read register in _rtl92de_query_rxphystatus > > Instead of reading bit 9 of RFPGA0_XA_HSSIPARAMETER2 every time a frame > is received, just use rtlphy->cck_high_power, which is initialised in > _rtl92d_phy_bb_config(). That bit never changes anyway. > > With this change _rtl92de_query_rxphystatus() can be shared with the > upcoming USB driver. The USB driver can't read registers in this > function because register reading can sleep. > > Compile tested only. > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > --- > "That bit never changes anyway." <- I'm 99% sure this is true. I can't find a RTL8192DE, but after checking RFPGA0_XA_HSSIPARAMETER2 and its address 0x824, I believe you are right. [...]
