Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote: > Currently most of the ath12k QMI messaging functions define their > struct qmi_txn variables with a {} initializer. However, all of these > functions subsequently call qmi_txn_init(), and the very first thing > that function does is zero the struct. Hence, the initializers are > unnecessary. Since these consume code space and cpu cycles, remove > them. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> 3 patches applied to ath-next branch of ath.git, thanks. 59cf57ab3dee wifi: ath12k: Remove unnecessary struct qmi_txn initializers 2e82b5f09a97 wifi: ath12k: Add missing qmi_txn_cancel() calls 6d2b0a066941 wifi: ath12k: Use initializers for QMI message buffers -- https://patchwork.kernel.org/project/linux-wireless/patch/20240111-qmi-cleanup-v2-1-53343af953d5@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches