On 1/11/2024 9:06 AM, benjamin@xxxxxxxxxxxxxxxx wrote: > From: Benjamin Berg <benjamin.berg@xxxxxxxxx> ... > #ifdef CONFIG_ATH11K_DEBUGFS > + .vif_add_debugfs = ath11k_debugfs_op_add_interface, nit: can we rename to ath11k_debugfs_op_vif_add()? this would follow the convention used by almost all of the other methods to use the name ath11k_<component>_op_<method>() but in this case dropping the redundant "debugfs" from the method I'll submit a separate patch to rename the method below to also align with that naming, ath11k_debugfs_op_sta_add() > .sta_add_debugfs = ath11k_debugfs_sta_op_add, > #endif >