Hi Arend On Fri, 2024-01-12 at 13:52 +0100, Arend Van Spriel wrote:On January 12, 2024 11:46:41 AM Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx> wrote:Hi guys I stumbled over this thread from a little over a year ago [1]. I lately tried my take at this, however, initially even on latest linux-next it did not even recognise my card. 0000:01:00.0 Network controller: Broadcom Inc. and subsidiaries Device 449d (rev 02) Once I added that PCI device ID to drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c the driver at least picked it up: [ 27.712436] brcmfmac 0000:01:00.0: enabling device (0000 -> 0002) [ 27.826371] brcmfmac 0000:01:00.0: brcmf_pcie_probe: failed to parse OTP [ 27.833126] brcmfmac: brcmf_pcie_probe: failed 14e4:449d [ 27.838498] brcmfmac: probe of 0000:01:00.0 failed with error -22 Looks like it needs more information but I am unsure to what exactly to add where. Last I got the following (git diff at the very end): [ 412.947747] brcmfmac 0000:01:00.0: enabling device (0000 -> 0002) [ 413.059831] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac43752-pcie for chip BCM43752/2 [ 413.096587] brcmfmac 0000:01:00.0: Direct firmware load for brcm/brcmfmac43752-pcie.txcap_blob failed with error -2 [ 419.211343] brcmfmac 0000:01:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize [ 419.219481] brcmfmac 0000:01:00.0: brcmf_pcie_setup: Dongle setup failed [ 419.226214] ieee80211 phy0: brcmf_fw_crashed: Firmware has halted or crashed Not sure what exact firmware I would need to use. From SparkLAN I got the following: Archive: FW_AP6275P_101_v2.zip Length Date Time Name --------- ---------- ----- ---- 80602 07-01-2021 15:01 FW_AP6275P_101_v2/BCM4362A2_001.003.006.1012.1017.hcd 30993 11-12-2021 20:16 FW_AP6275P_101_v2/clm_bcm43752a2_pcie_ag.blob 936074 07-13-2022 14:28 FW_AP6275P_101_v2/fw_bcm43752a2_pcie_ag.bin 7458 01-10-2022 12:11 FW_AP6275P_101_v2/nvram_ap6275p.txt 7808 08-30-2022 15:53 FW_AP6275P_101_v2/nvram_ap6275p_m2.txt 8576 02-25-2021 14:51 FW_AP6275P_101_v2/nvram_ap6275p_mp.txt 673 04-21-2023 16:32 FW_AP6275P_101_v2/ReadMe.txt --------- ------- 1072184 7 files Did anybody ever progress on getting this to work? Any help would be much appreciated.I assume you use the .bin and .blob already. Which n ram you need I don't know. Does the ReadMe have any clues on that?Yes, sorry, it does indeed: NVRAM file -------------------------------------------- WPEB-265AXI(BT) - use nvram_ap6575p_mp.txt WNFB-265AXI(BT) - use nvram_ap6575p_m2.txt AP6275P - use nvram_ap6575p.txtCypress/Infineon added 43752 SDIO support so I am not sure if your patch is correct in marking it as WCC chip.I am also not sure. I thought it was owned by Synaptics now.Can you run strings command on firmware file, ie.: # strings fw.bin | tail -5⬢[zim@toolbox FW_AP6275P_101_v2]$ strings fw_bcm43752a2_pcie_ag.bin | tail -5 7.K^ @% , @%",<UCODE-TAG>path=.../dot11_firmware/branches/BCM4362_LEM35RC387_1440_17800@40298 major=1440 minor=17800diff_ct=0 prebuilt=0<FW-TAG>4362a2-roml/config_pcie_ampak_release_he Version=18.35.387.23.146 (g412cc5ec) Date=2022-07-12T10:55:29ZFWID=01-93c53be6
The git hash is my only clue, but looks to be Synaptics indeed.
Also let's try to enable some debug levels. Can you enable CONFIG_BRCMDBG and rebuild the driver?Yes, let me try that and get back to you.Then load the driver module with debug parameter set to 0x1c1416.Okay.Regards, ArendCheers
I refreshed my memory reading the email conversation you referred to. What got things going was sending a seed to firmware after download. That is in the driver [1] but it's only done when otp is valid.
Maybe you can hack it to be unconditional and see where it gets you. Regards, Arend[1] https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c#L1714
MarcelThanks![1] https://lore.kernel.org/all/2db80338-c92d-b006-c281-dab943029168@xxxxxxxxxxx/T Cheers Marcel --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index 80220685f5e4..b596762a1cd2 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -66,6 +66,7 @@ BRCMF_FW_DEF(4365C, "brcmfmac4365c-pcie"); BRCMF_FW_DEF(4366B, "brcmfmac4366b-pcie"); BRCMF_FW_DEF(4366C, "brcmfmac4366c-pcie"); BRCMF_FW_DEF(4371, "brcmfmac4371-pcie"); +BRCMF_FW_CLM_DEF(43752, "brcmfmac43752-pcie"); BRCMF_FW_CLM_DEF(4377B3, "brcmfmac4377b3-pcie"); BRCMF_FW_CLM_DEF(4378B1, "brcmfmac4378b1-pcie"); BRCMF_FW_CLM_DEF(4378B3, "brcmfmac4378b3-pcie"); @@ -104,6 +105,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = { BRCMF_FW_ENTRY(BRCM_CC_43664_CHIP_ID, 0xFFFFFFF0, 4366C), BRCMF_FW_ENTRY(BRCM_CC_43666_CHIP_ID, 0xFFFFFFF0, 4366C), BRCMF_FW_ENTRY(BRCM_CC_4371_CHIP_ID, 0xFFFFFFFF, 4371), + BRCMF_FW_ENTRY(BRCM_CC_43752_CHIP_ID, 0xFFFFFFFF, 43752), BRCMF_FW_ENTRY(BRCM_CC_4377_CHIP_ID, 0xFFFFFFFF, 4377B3), /* revision ID 4 */ BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0x0000000F, 4378B1), /* revision ID 3 */ BRCMF_FW_ENTRY(BRCM_CC_4378_CHIP_ID, 0xFFFFFFE0, 4378B3), /* revision ID 5 */ @@ -2062,6 +2064,8 @@ static int brcmf_pcie_read_otp(struct brcmf_pciedev_info *devinfo) words = 0x170; break; case BRCM_CC_4387_CHIP_ID: +//brcmf_pcie_probe: failed to parse OTP +// case BRCM_CC_43752_CHIP_ID: coreid = BCMA_CORE_GCI; base = 0x113c; words = 0x170; @@ -2694,6 +2698,7 @@ static const struct pci_device_id brcmf_pcie_devid_table[] = { BRCMF_PCIE_DEVICE(BRCM_PCIE_4366_2G_DEVICE_ID, BCA), BRCMF_PCIE_DEVICE(BRCM_PCIE_4366_5G_DEVICE_ID, BCA), BRCMF_PCIE_DEVICE(BRCM_PCIE_4371_DEVICE_ID, WCC), + BRCMF_PCIE_DEVICE(BRCM_PCIE_43752_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_43596_DEVICE_ID, CYW), BRCMF_PCIE_DEVICE(BRCM_PCIE_4377_DEVICE_ID, WCC), BRCMF_PCIE_DEVICE(BRCM_PCIE_4378_DEVICE_ID, WCC), diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h index 44684bf1b9ac..b97b4c640d1b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h @@ -59,6 +59,7 @@ #define CY_CC_43012_CHIP_ID 43012 #define CY_CC_43439_CHIP_ID 43439 #define CY_CC_43752_CHIP_ID 43752 +#define BRCM_CC_43752_CHIP_ID 43752 /* USB Device IDs */ #define BRCM_USB_43143_DEVICE_ID 0xbd1e @@ -93,6 +94,7 @@ #define BRCM_PCIE_4366_2G_DEVICE_ID 0x43c4 #define BRCM_PCIE_4366_5G_DEVICE_ID 0x43c5 #define BRCM_PCIE_4371_DEVICE_ID 0x440d +#define BRCM_PCIE_43752_DEVICE_ID 0x449d #define BRCM_PCIE_43596_DEVICE_ID 0x4415 #define BRCM_PCIE_4377_DEVICE_ID 0x4488 #define BRCM_PCIE_4378_DEVICE_ID 0x4425
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
