Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 1/9/2024 6:16 PM, Baochen Qiang wrote: > >> On 1/10/2024 1:41 AM, Jeff Johnson wrote: >>> On 1/8/2024 6:13 PM, Baochen Qiang wrote: >>>> QCA2066 is a PCI based DBS device. It is very similar to WCN6855 >>>> overall: they share the same PCI device ID, the same major and >>>> minor version numbers, the same register address, and same HAL >>>> descriptors etc. The most significant difference is that QCA2066 >>>> supports 3-antenna configuration while WCN6855 does not. To differentiate >>>> them, subversion numbers are used. Currently four numbers are used >>>> by QCA2066: 0x1019A0E1, 0x1019B0E1, 0x1019C0E1 and 0x1019D0E1. >>>> >>>> Tested-on: QCA2066 hw2.1 PCI WLAN.HSP.1.1-03737-QCAHSPSWPL_V2_SILICONZ_CE-1 >>>> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 >>>> >>>> Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> >>>> --- >>>> v2: >>>> - Rebased on ToT. >>> >>> hmmm, fails to apply using b4 shazam >>> >>> Checking attestation on all messages, may take a moment... >>> --- >>> ✓ [PATCH v2 1/2] wifi: ath11k: move pci.ops registration ahead >>> ✓ [PATCH v2 2/2] wifi: ath11k: add support for QCA2066 >>> --- >>> ✓ Signed: DKIM/quicinc.com >>> --- >>> Total patches: 2 >>> --- >>> Base: using specified base-commit 2cd4e3f91f264926a6b11df948417b74d52ca9b9 >>> Applying: wifi: ath11k: move pci.ops registration ahead >>> Applying: wifi: ath11k: add support for QCA2066 >>> Patch failed at 0002 wifi: ath11k: add support for QCA2066 >>> error: patch failed: drivers/net/wireless/ath/ath11k/core.c:711 >>> error: drivers/net/wireless/ath/ath11k/core.c: patch does not apply >>> >>> And sure enough the code at drivers/net/wireless/ath/ath11k/core.c:711 >>> doesn't match the code in the 2nd patch so something is amiss here. >>> >>> note your patch has reference to .support_dual_stations that is not >>> present in ath11k -- perhaps there are other prerequisites? >>> <https://patchwork.kernel.org/project/linux-wireless/patch/20230714023801.2621802-2-quic_cjhuang@xxxxxxxxxxx/> >> Yes, as said in the cover letter, this patch set depends on the above patch. > > Unfortunately automated tasks don't parse cover letters. But it looks > like b4 doesn't handle or warn about: > prerequisite-patch-id: 640366721125b1adea0eeabd5cdfca5e91476e7c > > And not quite sure how it would handle that. > > Kalle, that prerequisite series is set to Deferred and predates my > transition to the ath11k maintainer role. What action is needed from the > developers? > <https://patchwork.kernel.org/project/linux-wireless/list/?series=765506&state=*> My plan was to run some tests on that patch before applying it, that's why it's deferred for now. I'll try to do that soon. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
