> -----Original Message----- > From: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> > Sent: Wednesday, January 10, 2024 6:39 PM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; Ping-Ke Shih > <pkshih@xxxxxxxxxxx>; Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>; Sebastian Andrzej Siewior > <bigeasy@xxxxxxxxxxxxx> > Subject: [PATCH v2] wifi: rtl8xxxu: enable channel switch support > > The CSA countdown in the beacon frames, which are sent out by firmware, > needs to get updated by the driver. To achieve this, convert > update_beacon_work to delayed_work and schedule it with the beacon > interval in case CSA is active and the countdown is not complete. > > Signed-off-by: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> > --- > changes v1->v2: use delayed_work instead of usleep_range > v1: https://lore.kernel.org/linux-wireless/20240108111103.121378-1-martin.kaistra@xxxxxxxxxxxxx/ > .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- > .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 18 ++++++++++++++---- > 2 files changed, 15 insertions(+), 5 deletions(-) > [...] > @@ -7764,7 +7772,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface, > spin_lock_init(&priv->rx_urb_lock); > INIT_WORK(&priv->rx_urb_wq, rtl8xxxu_rx_urb_work); > INIT_DELAYED_WORK(&priv->ra_watchdog, rtl8xxxu_watchdog_callback); > - INIT_WORK(&priv->update_beacon_work, rtl8xxxu_update_beacon_work_callback); > + INIT_DELAYED_WORK(&priv->update_beacon_work, rtl8xxxu_update_beacon_work_callback); It seems like we missed cancel priv->update_beacon_work work at rtl8xxxu_stop(). Because that isn't introduced by this patch, you can decide to do it in this patch or not. Also, 'struct work_struct c2hcmd_work;' has similar problem. This could be a problem theoretically, but not easy to see the problem though. > skb_queue_head_init(&priv->c2hcmd_queue); > > usb_set_intfdata(interface, hw); [...]
