Search Linux Wireless

Re: [PATCH] wifi: rtw89: 8852b: fix cppcheck issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2024-01-05 at 18:45 +0800, lilinmao wrote:
> cppcheck reports

[snip]

Look ... you really should write up an explanation of what the patch is
doing, whether the tool is correct or not, etc.

Please don't blindly paste some checker messages and make random changes
to the code to suppress them. We get too many such patches. Convince us
with a useful commit message that you've actually thought about it.

> Fixes: f2abe804e823 ("wifi: rtw89: 8852b: rfk: add IQK")

Really not much point in that, since it clearly doesn't actually _fix_
anything.


johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux