> -----Original Message----- > From: reinette chatre [mailto:reinette.chatre@xxxxxxxxx] > Sent: Tuesday, November 25, 2008 1:33 PM > To: Helmut Schaa > Cc: ipw2100-devel@xxxxxxxxxxxxxxxxxxxxx; Zhu, Yi; > linux-wireless@xxxxxxxxxxxxxxx; linville@xxxxxxxxxxxxx > Subject: Re: [Ipw2100-devel] [PATCH] ipw2200: increase scan timeout > > On Tue, 2008-11-25 at 09:09 -0800, Helmut Schaa wrote: > > The current scan timeout is set to 5 seconds. If the timeout is hit > > because the firmware did not respond yet, the adapter gets > restarted, > > which results in a disassociation. > > > > However, in an environment with lots of access points the scan > > sometimes takes longer than 5 seconds. This patch simply > increases the timeout to 10 seconds. > > > > Signed-off-by: helmut.schaa@xxxxxxxxxxxxxx > > --- > > > > I was able to reproduce the issue fairly reliable with a > 2915 adapter > > by periodically triggering scans while associated. > > > > I have no idea in which situations the scan takes longer than 5 > > seconds to complete but maybe it might even take longer than 10 > > seconds. Has anybody from Intel insight into the firmware scan code? > > > > diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c > > b/drivers/net/wireless/ipw2x00/ipw2200.c > > index c73173a..a776da3 100644 > > --- a/drivers/net/wireless/ipw2x00/ipw2200.c > > +++ b/drivers/net/wireless/ipw2x00/ipw2200.c > > @@ -2304,7 +2304,7 @@ static void > ipw_bg_adapter_restart(struct work_struct *work) > > mutex_unlock(&priv->mutex); > > } > > > > -#define IPW_SCAN_CHECK_WATCHDOG (5 * HZ) > > +#define IPW_SCAN_CHECK_WATCHDOG (10 * HZ) > > > > static void ipw_scan_check(void *data) { > > I do not have insight into the scan code ... but I can try to > find out if there is something specific you need to know. > > This change seems harmless and if it helps you it may help > somebody else too. It seems harmless to me also, and if anyone is getting burned by it timing out before a scan is complete, then it seems like a good idea. It's just a "safety net", and should not affect the *actual* time spent scanning. -- Ben -- > > Acked-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> > > Thank you > > Reinette > > > -------------------------------------------------------------- > ----------- > This SF.Net email is sponsored by the Moblin Your Move > Developer's challenge Build the coolest Linux based > applications with Moblin SDK & win great prizes Grand prize > is a trip for two to an Open Source event anywhere in the > world http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > ipw2100-devel mailing list > ipw2100-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.sourceforge.net/lists/listinfo/ipw2100-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
