Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote: > Currently struct wmi_host_mem_chunks defines: > struct host_memory_chunk items[1]; > > Per the guidance in [1] this should be a flexible array. However there > is a documented requirement: > some fw revisions require at least 1 chunk regardless of count > > To satisfy this requirement, follow the guidance from [2] and wrap the > array in a union which contains both the flexible array and a single > instance of the underlying struct. Since the footprint of the struct > is unchanged, no additional driver changes are required. > > No functional changes, compile tested only. > > [1] https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays > [2] https://lore.kernel.org/linux-wireless/202308301529.AC90A9EF98@keescook/ > > Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > Reviewed-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> 6 patches applied to ath-next branch of ath.git, thanks. d2eb318f4b6b wifi: ath10k: use flexible array in struct wmi_host_mem_chunks 72ca7c4073ac wifi: ath10k: use flexible arrays for WMI start scan TLVs 26eb704a46f8 wifi: ath10k: remove struct wmi_pdev_chanlist_update_event b0c0794b05ec wifi: ath10k: remove unused template structs cb188e862c1c wifi: ath10k: use flexible array in struct wmi_tdls_peer_capabilities 6b9923f1f6d1 wifi: ath10k: remove duplicate memset() in 10.4 TDLS peer update -- https://patchwork.kernel.org/project/linux-wireless/patch/20231213-wmi_host_mem_chunks_flexarray-v1-1-92922d92fa2c@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
