>> On 12/16/23 10:52, Zenm Chen wrote: >> Add additional USB IDs found in the vendor driver from >> https://github.com/Mange/rtl8192eu-linux-driver to support more >> RTL8192EU devices. >> >> Signed-off-by: Zenm Chen <zenmchen@xxxxxxxxx> >> --- >> v2: >> - Not to put these USB IDs in CONFIG_RTL8XXXU_UNTESTED > > Have you tested all modes including STA, AP, P2P, etc? If not, then your devices > belong in the CONFIG_RTL8XXXU_UNTESTED section. You're right, I haven't tested these four devices, so they should be in the CONFIG_RTL8XXXU_UNTESTED section. Please drop this patch, thanks. > > I am also not fond of splitting the rtl8192eu devices into several different > spots in the table. That only makes it harder to see what devices are supported. > > NACKed by Larry Finger <Larry.Finger@xxxxxxxxxxxx> > > Larry