Hello, I indeed intend to fix the driver to do the buffering and use _get_buffered_bc() (and also add sequence numbering, which is easier). It will take time to fix it and to test it with hostapd and clients. When it will be ready, the only thing which will be needed is to remove the "hw->wiphy->ap_ps_challenged = true" from zd_mac_alloc_hw() in zd_mac.c. The other changes in the driver should of course stay (adding handling of NL80211_IFTYPE_AP). As far as I understand, the zd1211rw is not the only one which does not support buffering; (and I assume there will be other such drivers without this support in the future); so it seems to me that the nl80211 patch, which enable users who would prefer to have an AP that can't support fully PS clients, rather than not having an AP at all, is a good enough reason for the nl80211 patch. Using Linux as an access point with a standard and a wide range of commodity wireless drivers seems really a nice and important feature. Regards, Rami Rosen On Mon, Nov 24, 2008 at 1:21 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2008-11-24 at 13:09 +0200, Rami Rosen wrote: > >> If you are talking about whether the zd1211 driver can buffer >> mcast/bcast frames in software, it seems to me that the answer is >> negative, since there is no call for ieee80211_get_buffered_bc() in >> the zd1211rw driver code and also there is no handling of >> IEEE80211_TX_CTL_SEND_AFTER_DTIM or >> IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING in the zd1211rw driver code. >> This what made me add the NL80211_ATTR_WIPHY_AP_PS_CHALLENGED >> attribute and prepare this patch. > > Yes, I know that's why you did it, but I'm still wondering whether it > was necessary, is it really impossible to implement mcast/bcast > buffering with this hardware? IOW, can we fix the driver to do the > buffering and using _get_buffered_bc()? > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
