Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > From: Chia-Yuan Li <leo.li@xxxxxxxxxxx> > > To diagnose the reason why firmware or hardware get abnormal, add to dump > MAC registers related to counters and interrupt masks. With these values, > people can classify problems and check if registers values are unexpected, > and then correct them. However, it could possible false alarm because > firmware triggers this SER event by wrong conditions that we should > correct it at firmware or register settings. > > In field, SER might happen under special conditions, and very hard to > happen again, so dump lots of registers to provide rich information to > catch the problem. > > Signed-off-by: Chia-Yuan Li <leo.li@xxxxxxxxxxx> > Signed-off-by: Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> I can understand printing few essential firmware/hardware information to dmesg but from quickly looking at the patch it looks like rtw89 is dumping A LOT of values during a firmware crash. I think that's too extensive and other means should be considered, for example providing the data using coredump framework. This is not a blocker but more like a comment for future design decisions. -- https://patchwork.kernel.org/project/linux-wireless/patch/20231204080751.15354-5-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
