> Fails to compile. Makes me wonder how did you even test this?
>
> drivers/net/wireless/ath/ath12k/mac.c:7743:20: error: conflicting types for
> 'ath12k_mac_he_gi_to_nl80211_he_gi' due to enum/integer mismatch; have
> 'enum nl80211_he_gi(u8)' {aka 'enum nl80211_he_gi(unsigned char)'} [-
> Werror=enum-int-mismatch]
> 7743 | enum nl80211_he_gi ath12k_mac_he_gi_to_nl80211_he_gi(u8 sgi)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/net/wireless/ath/ath12k/mac.c:9:
> drivers/net/wireless/ath/ath12k/mac.h:79:5: note: previous declaration of
> 'ath12k_mac_he_gi_to_nl80211_he_gi' with type 'u32(u8)' {aka 'unsigned
> int(unsigned char)'}
> 79 | u32 ath12k_mac_he_gi_to_nl80211_he_gi(u8 sgi);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[7]: *** [scripts/Makefile.build:243:
> drivers/net/wireless/ath/ath12k/mac.o] Error 1
> make[6]: *** [scripts/Makefile.build:480: drivers/net/wireless/ath/ath12k]
> Error 2
> make[5]: *** [scripts/Makefile.build:480: drivers/net/wireless/ath] Error 2
> make[4]: *** [scripts/Makefile.build:480: drivers/net/wireless] Error 2
> make[3]: *** [scripts/Makefile.build:480: drivers/net] Error 2
> make[2]: *** [scripts/Makefile.build:480: drivers] Error 2
> make[1]: ***
> [/home/kvalo/projects/atheros/ath10k/src/ath/Makefile:1913: .] Error 2
> make: *** [Makefile:234: __sub-make] Error 2
>
> Patch set to Changes Requested.
Hi kalle,
I didn't have this issue when I test it yesterday.
It may be that the version of our gcc is not the same.
My DUT's gcc version 11.4.0.
I have sent the patch v2.
Best regards
Lingbo Kong
> --
> https://patchwork.kernel.org/project/linux-
> wireless/patch/20231206134654.24662-1-quic_lingbok@xxxxxxxxxxx/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa
> tches
