Is this correct to commit inline patches?
Looks for me similar to this one
https://lore.kernel.org/linux-wireless/20231127162022.518834-2-kvalo@xxxxxxxxxx/T/#u
subject: [RFC PATCH] wifi: rtl8xxxu: Add new device ID
This patch will add a new device ID (2357:0126)
Patch will close: https://bugzilla.kernel.org/show_bug.cgi?id=218231
TP-Link TL-WN8200ND(UN) v3.0
ID 2357:0126 TP-Link 802.11n NIC
https://www.tp-link.com/de/home-networking/adapter/tl-wn8200nd/
Sold in Germany.
tested:
[ 855.204083] usb 1-9.3: New USB device found, idVendor=2357, idProduct=0126, bcdDevice= 2.00
[ 855.204091] usb 1-9.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 855.204094] usb 1-9.3: Product: 802.11n NIC
[ 855.204096] usb 1-9.3: Manufacturer: Realtek
[ 855.204097] usb 1-9.3: SerialNumber: 5091E3C3A09F
[ 855.242127] usb 1-9.3: This Realtek USB WiFi dongle (0x2357:0x0126) is untested!
[ 855.242134] usb 1-9.3: Please report results to Jes.Sorensen@xxxxxxxxx
[ 859.592016] usb 1-9.3: Dumping efuse for RTL8192EU (0x200 bytes):
[ 859.592024] 00000000: 29 81 00 7c 01 40 03 00 70 34 04 50 14 00 00 00 )..|.@..p4.P....
[ 859.592027] 00000010: 20 20 20 21 21 21 28 28 28 28 28 f0 00 ef ff ff !!!(((((.....
[ 859.592028] 00000020: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592030] 00000030: ff ff ff ff ff ff ff ff ff ff 2d 2d 2d 2d 2d 2d ..........------
[ 859.592031] 00000040: 2d 2d 2d 2d 2d f0 ef ef ff ff ff ff ff ff ff ff -----...........
[ 859.592032] 00000050: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592034] 00000060: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592035] 00000070: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592036] 00000080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592038] 00000090: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592039] 000000a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592040] 000000b0: ff ff ff ff ff ff ff ff a1 1f 1a 00 00 00 ff ff ................
[ 859.592041] 000000c0: ff 01 00 10 00 00 00 ff 00 00 31 ff ff ff ff ff ..........1.....
[ 859.592043] 000000d0: 57 23 26 01 e6 47 02 50 91 e3 c3 a0 9f 09 03 52 W#&..G.P.......R
[ 859.592044] 000000e0: 65 61 6c 74 65 6b 0d 03 38 30 32 2e 31 31 6e 20 ealtek..802.11n
[ 859.592046] 000000f0: 4e 49 43 00 ff ff ff ff ff ff ff ff ff ff ff ff NIC.............
[ 859.592047] 00000100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592048] 00000110: ff ff ff ff ff ff ff 0d 03 00 05 00 30 00 00 00 ............0...
[ 859.592050] 00000120: 00 93 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592051] 00000130: f6 a8 98 2d 03 92 98 00 fc 8c 00 11 9b 44 02 0a ...-.........D..
[ 859.592052] 00000140: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592053] 00000150: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592055] 00000160: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592056] 00000170: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592057] 00000180: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592059] 00000190: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592060] 000001a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592061] 000001b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592062] 000001c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592064] 000001d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592065] 000001e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592066] 000001f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
[ 859.592068] usb 1-9.3: RTL8192EU rev B (SMIC) romver 0, 2T2R, TX queues 3, WiFi=1, BT=0, GPS=0, HI PA=0
[ 859.592072] usb 1-9.3: RTL8192EU MAC: 50:91:e3:c3:a0:9f
[ 859.592074] usb 1-9.3: rtl8xxxu: Loading firmware rtlwifi/rtl8192eu_nic.bin
[ 859.600070] usb 1-9.3: Firmware revision 35.7 (signature 0x92e1)
[ 868.683025] rtl8xxxu 1-9.3:1.0 wlp22s0f0u9u3: renamed from wlan0
$ iw dev
phy#1
Interface wlp22s0f0u9u3
ifindex 4
wdev 0x100000001
addr 50:91:e3:c3:a0:9f
type managed
txpower 20.00 dBm
multicast TXQ:
qsz-byt qsz-pkt flows drops marks overlmt hashcol tx-bytes tx-packets
0 0 0 0 0 0 0 0 0
$
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 43ee7592bc6e..47b5e6d20e54 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -7957,6 +7957,8 @@ static const struct usb_device_id dev_table[] = {
/* found in rtl8192eu vendor driver */
{USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0107, 0xff, 0xff, 0xff),
.driver_info = (unsigned long)&rtl8192eu_fops},
+{USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x0126, 0xff, 0xff, 0xff),
+ .driver_info = (unsigned long)&rtl8192eu_fops},
{USB_DEVICE_AND_INTERFACE_INFO(0x2019, 0xab33, 0xff, 0xff, 0xff),
.driver_info = (unsigned long)&rtl8192eu_fops},
{USB_DEVICE_AND_INTERFACE_INFO(USB_VENDOR_ID_REALTEK, 0x818c, 0xff, 0xff, 0xff),
Signed-off-by: Michael Dieckmann <zerobeat@xxxxxx>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 ++
Am 07.12.23 um 09:52 schrieb Ping-Ke Shih:
-----Original Message-----
From: ZeroBeat <ZeroBeat@xxxxxx>
Sent: Thursday, December 7, 2023 4:46 PM
To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx; Jes.Sorensen@xxxxxxxxx
Subject: Re: [PATCH] wifiwifi: Realtek: rtl8xxxu Add new device ID
Better now?
Your patch isn't much like others. Please check patches [1] made by others.
[1] https://lore.kernel.org/linux-wireless/
