On Fri, Dec 01, 2023 at 11:05:47PM +0000, David Lin wrote:
> > On Tue, Nov 28, 2023 at 04:31:03PM +0800, David Lin wrote:
> > > 5. Address reviewer comments.
> > You should list the changes you did, something that generic is forcing the
> > reviewer to compare v7 vs v6 to known what changed.
>
> Can I summary what should I do and hopefully I can make agreement with you:
>
> 1. Separate patch v7 6/12 as a single patch.
> 2. Merged all other patches as a single patch for host mlme.
I would suggest to proceed the following way:
1. v8 of this series should have only 2 patches
- PATCH v8 1/2 : add host mle station support.
- PATCH v8 2/2 : add host mle AP support.
Any kind of fix on these 2 new functionalities should be squashed in
these single 2 patches. No commit to add a functionality with a bug
that is fixed with a follow-up commit. If you discover bugs during
your testing this is great, just amend the original commit that
introduced it.
I am assuming that is fair to implement station and AP support in
separated patches, please speak up if this is not the case.
2. PATCH v7 06/12: this should be send as a new separate patch, with a
Fixes: tag and Cc:stable.
> So there should be no patch v8 and only have two patches, one for host
> mlme and another one to fix hostap restart issue.
It's ok to have a v8, restarting another series will be even more
confusing IMO.
Thanks!
Francesco
