Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Reviewed-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. afb154426bf1 wifi: brcmfmac: Convert to platform remove callback returning void -- https://patchwork.kernel.org/project/linux-wireless/patch/20231117093056.873834-13-u.kleine-koenig@xxxxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
