On Thu, 2023-11-30 at 10:52 -0800, Kees Cook wrote:
>
> I was able to see it with Ubuntu's GCC 12.3.0 and their config. This
> fixed it for me:
OK. I guess kernel tree also mattered somehow, and I got confused
because I'd applied the patch on wireless, where the robot did it on
wireless-next. Not sure how that's different, but OK.
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index d0f499227c29..7735d178a393 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -12845,7 +12845,7 @@ static int cfg80211_cqm_rssi_update(struct cfg80211_registered_device *rdev,
> }
>
> static int nl80211_set_cqm_rssi(struct genl_info *info,
> - const s32 *thresholds, int n_thresholds,
> + const s32 *thresholds, u32 n_thresholds,
> u32 hysteresis)
> {
> struct cfg80211_registered_device *rdev = info->user_ptr[0];
> @@ -12948,7 +12948,7 @@ static int nl80211_set_cqm(struct sk_buff *skb, struct genl_info *info)
> attrs[NL80211_ATTR_CQM_RSSI_HYST]) {
> const s32 *thresholds =
> nla_data(attrs[NL80211_ATTR_CQM_RSSI_THOLD]);
> - int len = nla_len(attrs[NL80211_ATTR_CQM_RSSI_THOLD]);
> + u32 len = nla_len(attrs[NL80211_ATTR_CQM_RSSI_THOLD]);
> u32 hysteresis = nla_get_u32(attrs[NL80211_ATTR_CQM_RSSI_HYST]);
>
> if (len % 4)
>
>
> If that's sensible, I can send a proper patch?
Sure, that seems reasonable.
> (Oh, it looks like nla_len is actually u16 ... should I use that instead
> of u32?)
Yeah it's a 16-bit field in the message format. Doesn't really matter?
johannes
