Search Linux Wireless

RE: [PATCH 4/6] wifi: cfg80211: Schedule regulatory check on BSS STA channel change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> cfg80211_valid_disable_subchannel_bitmap(u16 *bitmap,
> >   * case disconnect instead.
> >   * Also note that the wdev mutex must be held.
> >   */
> > +
> >  void cfg80211_links_removed(struct net_device *dev, u16 link_mask);
> 
> What happened there?

No idea, it wasn't in the original patch.. Will recheck with Gregory and fix it.

> 
> > +void cfg80211_schedule_channels_check(struct net_device *netdev) {
> > +	struct wireless_dev *wdev = netdev->ieee80211_ptr;
> > +	struct wiphy *wiphy = wdev->wiphy;
> > +
> > +	/* Schedule channels check if NO_IR or DFS relaxations are
> supported */
> > +	if (wdev->iftype == NL80211_IFTYPE_STATION &&
> > +	    (wiphy_ext_feature_isset(wiphy,
> > +
> NL80211_EXT_FEATURE_DFS_CONCURRENT) ||
> > +	    (IS_ENABLED(CONFIG_CFG80211_REG_RELAX_NO_IR) &&
> > +	     wiphy->regulatory_flags &
> REGULATORY_ENABLE_RELAX_NO_IR)))
> > +		reg_check_channels();
> > +}
> 
> That ... doesn't even use the netdev pointer, apart from going to the wiphy?
> Why not have a wiphy argument instead?

We do need wdev here, I will change it to be wireless device instead

> 
> johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux