On Fri, 17 Nov 2023, Bjorn Helgaas wrote: > On Fri, Nov 17, 2023 at 11:44:25AM +0200, Ilpo Järvinen wrote: > > _rtl8821ae_clear_pci_pme_status() accesses the upper byte of the Power > > Management Control/Status register (PMCS) with literal 5 offset. > > > > Access the entire PMCS register using defines from pci_regs.h to > > improve code readability. > > > > While at it, remove the obvious comment and tweak debug prints > > slightly to not sound misleading. > > OK, ignore my previous comments ;) I should read all the way through > before responding. Please don't do that because then you'll just end up forgetting useful comments. :-) I had this all in one patch initially but thought it's better to split it a bit. Thanks a lot for reviewing. -- i.
