Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 11/13/2023 7:35 AM, James Prestwood wrote: >> Let ath11k select this option automatically which makes building >> more intuitive if the user enables this driver (rather than the >> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled) > > s/MICAEL/MICHAEL/ > > add hard stop > > Also suggest you include (or summarize) the information that Kalle > shared that ath is the outlier here: > > Further investigation shows that ath11k and ath12k are the only who use > 'depends on' with CRYPTO_MICHAEL_MIC: > > ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC > ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC > ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC > ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC > > consider these comments apply to ath12k change as well :) BTW I can add these changes in the pending branch, no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
