> -----Original Message-----
> From: Dmitry Antipov <dmantipov@xxxxxxxxx>
> Sent: Monday, November 13, 2023 10:47 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; lvc-project@xxxxxxxxxxxxxxxx; Dmitry
> Antipov <dmantipov@xxxxxxxxx>
> Subject: [PATCH 1/2] wifi: rtlwifi: more cleanup for struct rtl_hal
>
> Following commit d1e6b020c32d ("wifi: rtlwifi: cleanup struct rtl_hal"),
> remove unused 'hal_coex_8723', 'current_bandtypebackup', 'master_of_dmsp'
> and 'slave_of_dmsp' members of 'struct rtl_hal' as well. Compile tested
> only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtlwifi/wifi.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> index 171a461cd812..33c3e001266f 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> @@ -1605,7 +1605,6 @@ struct rtl_hal {
> bool being_init_adapter;
> bool mac_func_enable;
> bool pre_edcca_enable;
> - struct bt_coexist_8723 hal_coex_8723;
In drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c, it does a global
static variable:
static struct bt_coexist_8723 hal_coex_8723;
That's not a good practice. It would be better to use the field you are removing.
To prevent wasting space, we can dynamically allocate the space when 8723AE
is presented only.
Note, I don't have this old module 8723AE, so even you achieve the patch,
I can't test it on a real hardware.
