On 2023/11/13 20:07, Kalle Valo wrote:
Su Hui <suhui@xxxxxxxxxxxx> writes:
On 2023/11/13 14:16, Kalle Valo wrote:
Su Hui <suhui@xxxxxxxxxxxx> writes:
wl1271_acx_beacon_filter_opt() return error code if failed, add a check
for this is better and safer.
Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
How did you test this?
Only compile test.
If you have only compile tested please document that clearly in the
commit message.
Sorry for the unclear commit message.
Clang static checker complains about this code that value stored to
'ret' is never read.
This would be good to also have in the commit message.
I will add this to v2 patch if pass a test in a real device.
And most of the caller check the error code of
wl1271_acx_beacon_filter_opt().
This might still break something so I would prefer to test this in a
real device before taking it.
This might take some time, I try to find a wlcore device to test this.
Thanks for your reply!
Su Hui
