Hi Kalle,
On 11/13/23 7:50 AM, Kalle Valo wrote:
James Prestwood <prestwoj@xxxxxxxxx> wrote:
Advertise support for multicast frame registration and update the RX
filter with FIF_MCAST_ACTION to allow broadcast action frames to be
received. Broadcast action frames are needed for the Device
Provisioning Protocol (DPP) for Presence and PKEX Exchange requests.
Signed-off-by: James Prestwood <prestwoj@xxxxxxxxx>
Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>
On what hardware and firmware did you test with this? As there's so many
different combinations in ath10k we use Tested-on tag to document that.
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag
As ath10k hardware and firmware can work very differently from each other I'm
suspicious if this feature really work in all of them.
I only tested on a QCA6174 (and I'll add Tested-on for that). This makes
sense and maybe enabling unconditionally for all ath10k hardware is the
wrong way to go about it.
Since I don't have the ability to test every hardware combination
hopefully someone from atheros can chime in. Is there some
firmware/driver value that can be queried which tells me if broadcast RX
is supported? Or if not is checking ar->hw_rev == ATH10K_HW_QCA6174 good
enough? Or are there sub-variants that may or may not support this?
Thanks
James
