Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > To notify firmware TDMA timeslot assignment, append TDMA parameters when > sending policy H2C firmware command. However, compiler warns we do memcpy() > data to val[] field of TLV struct. To avoid this, assign the struct value > with simple '=' instead. Compile tested only. > > rtw89/coex.c: In function '_append_tdma': > drivers/net/wireless/realtek/rtw89/coex.c:1585:17: > warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=] > 1585 | memcpy(&v3->tdma, &dm->tdma, sizeof(v3->tdma)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from drivers/net/wireless/realtek/rtw89/coex.h:8, > from drivers/net/wireless/realtek/rtw89/coex.c:5: > drivers/net/wireless/realtek/rtw89/core.h:2703:37: > note: at offset [5714, 71249] into destination object 'ver' of size 8 > 2703 | const struct rtw89_btc_ver *ver; > | ^~~ > drivers/net/wireless/realtek/rtw89/coex.c:1579:17: > warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=] > 1579 | memcpy(v, &dm->tdma, sizeof(*v)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/realtek/rtw89/core.h:2703:37: > note: at offset [5710, 71245] into destination object 'ver' of size 8 > 2703 | const struct rtw89_btc_ver *ver; > | ^~~ > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202310301908.Wrj0diqe-lkp@xxxxxxxxx/ > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. ca76817f4c4b wifi: rtw89: coex: use struct assignment to replace memcpy() to append TDMA content -- https://patchwork.kernel.org/project/linux-wireless/patch/20231102003716.25815-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
