On Wed, 2023-11-08 at 16:44 +0100, Johannes Berg wrote: > > > I have been running similar code for...like 15 years, and haven't seen this particular > > deadlock before, so I think it is at least exacerbated by the locking changes. Or maybe > > I had particularly bad luck yesterday.... > > Oh, it almost certainly did get at least worse or perhaps introduced by > (a) moving everything to a single lock and (b) moving debugfs file > removal under the lock. > FWIW, the debugfs remove was under lock before, but we didn't acquire much locks in the debugfs itself (only sta mtx and only in aql write, and that mutex isn't held in remove) ... So indeed it couldn't happen. I added that to call into drivers with the wiphy mutex though, can't really remove that, I think. johannes
