> -----Original Message-----
> From: Dmitry Antipov <dmantipov@xxxxxxxxx>
> Sent: Monday, October 30, 2023 5:32 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Dmitry Antipov <dmantipov@xxxxxxxxx>
> Subject: [PATCH 1/2] wifi: rtw88: simplify rtw_chip_cfg_csi_rate()
>
> Since fix rate flag in 'rtw_dynamic_csi_rate()' is a hardcoded
> zero and actually unused in an underlying 'rtw_bf_cfg_csi_rate()',
> simplify 'rtw_chip_cfg_csi_rate()' by dropping last argument and
> adjust '(*cfg_csi_rate)()' of 'struct rtw_chip_ops' accordingly.
>
> Briefly tested on the following USB dongle:
>
> usb 3-6: new high-speed USB device number 7 using xhci_hcd
> usb 3-6: New USB device found, idVendor=0bda, idProduct=b812, bcdDevice=2.10
> usb 3-6: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 3-6: Product: USB3.0 802.11ac 1200M Adapter
> usb 3-6: Manufacturer: Realtek
> usb 3-6: SerialNumber: 123456
> rtw_8822bu 3-6:1.0: Firmware version 27.2.0, H2C version 13
> usbcore: registered new interface driver rtw_8822bu
>
> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtw88/bf.c | 2 +-
> drivers/net/wireless/realtek/rtw88/bf.h | 9 +++++----
> drivers/net/wireless/realtek/rtw88/main.c | 4 +---
> drivers/net/wireless/realtek/rtw88/main.h | 2 +-
> 4 files changed, 8 insertions(+), 9 deletions(-)
>
[...]
> diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
> index 4a33d2e47f33..4ea2f09709b0 100644
> --- a/drivers/net/wireless/realtek/rtw88/main.c
> +++ b/drivers/net/wireless/realtek/rtw88/main.c
> @@ -170,7 +170,6 @@ struct rtw_watch_dog_iter_data {
> static void rtw_dynamic_csi_rate(struct rtw_dev *rtwdev, struct rtw_vif *rtwvif)
> {
> struct rtw_bf_info *bf_info = &rtwdev->bf_info;
> - u8 fix_rate_enable = 0;
rtw88 is still active and possible to tune this parameter for certain circumstances,
and this parameter is helpful to understand current configuration, so I would tend
to not merge this patchset.
Ping-Ke
