On Fri Oct 27, 2023 at 10:25 AM CEST, Kalle Valo wrote: > Luca Weiss <luca.weiss@xxxxxxxxxxxxx> writes: > > > If we already have gotten the rproc_handle (meaning the "qcom,rproc" > > property is defined in the devicetree), it's a valid state that the > > remoteproc module hasn't probed yet so we should defer probing instead > > of just failing to probe. > > > > This resolves a race condition when the ath11k driver probes and fails > > before the wpss remoteproc driver has probed, like the following: > > > > [ 6.232360] ath11k 17a10040.wifi: failed to get rproc > > [ 6.232366] ath11k 17a10040.wifi: failed to get rproc: -22 > > [ 6.232478] ath11k: probe of 17a10040.wifi failed with error -22 > > ... > > [ 6.252415] remoteproc remoteproc2: 8a00000.remoteproc is available > > [ 6.252776] remoteproc remoteproc2: powering up 8a00000.remoteproc > > [ 6.252781] remoteproc remoteproc2: Booting fw image qcom/qcm6490/fairphone5/wpss.mdt, size 7188 > > > > So, defer the probe if we hit that so we can retry later once the wpss > > remoteproc is available. > > > > Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> > > Did you test this on a real device? If yes, what ath11k hardware and firmware > did you use? We use Tested-on tag to document that: > > https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag Hi, Yes I tested this on qcm6490-fairphone-fp5 including some extra patches for wpss-pas remoteproc support (nothing special, just adding it to the existing PAS driver) and wifi enablement in dts. I built this line from info from the dmesg, hope it's okay: Tested-on: wcn6750 hw1.0 AHB WLAN.MSL.1.0.1-01264-QCAMSLSWPLZ-1.37886.3 And thinking about it, a Fixes tag would also be appropriate for this patch. The code was moved to a different file in commit ba929d6fe31a ("ath11k: Remove rproc references from common core layer") but I think this tag should be correct. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > > I can add that in the pending branch if you provide the info. Thanks! Regards Luca
