> From: Francesco Dolcini <francesco@xxxxxxxxxx>
> Sent: Saturday, October 21, 2023 11:59 PM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Sharvari
> Harisangam <sharvari.harisangam@xxxxxxx>; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH v6 1/6] wifi: mwifiex: added code to support host
> mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> Hello David,
> thanks for your patch.
>
> On Fri, Oct 20, 2023 at 03:48:11AM +0000, David Lin wrote:
> > 1. For station mode first.
> > 2. This feature is a must for WPA3.
> > 3. Firmware key api version 2 is needed for this feature.
> > 4. The code is only enabled and tested with IW416.
> > 5. This feature is disabled for other chips.
> >
> > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx>
> > ---
> > .../net/wireless/marvell/mwifiex/cfg80211.c | 327
> ++++++++++++++++++
> > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 14 +-
> > drivers/net/wireless/marvell/mwifiex/decl.h | 12 +
> > drivers/net/wireless/marvell/mwifiex/fw.h | 15 +
> > drivers/net/wireless/marvell/mwifiex/init.c | 3 +
> > drivers/net/wireless/marvell/mwifiex/join.c | 64 +++-
> > drivers/net/wireless/marvell/mwifiex/main.h | 10 +
> > drivers/net/wireless/marvell/mwifiex/scan.c | 6 +
> > drivers/net/wireless/marvell/mwifiex/sdio.c | 13 +
> > drivers/net/wireless/marvell/mwifiex/sdio.h | 2 +
> > .../net/wireless/marvell/mwifiex/sta_event.c | 18 +-
> > .../net/wireless/marvell/mwifiex/sta_ioctl.c | 3 +-
> > drivers/net/wireless/marvell/mwifiex/sta_tx.c | 9 +-
> > .../net/wireless/marvell/mwifiex/uap_cmd.c | 26 ++
> > drivers/net/wireless/marvell/mwifiex/util.c | 73 ++++
> > 15 files changed, 582 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > index 7a15ea8072e6..40c39e4765f7 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > @@ -57,6 +57,31 @@ ieee80211_iface_combination
> mwifiex_iface_comb_ap_sta_drcs = {
> > .beacon_int_infra_match = true,
> > };
> >
> > +struct mwifiex_ieee80211_mgmt {
> > + __le16 frame_control;
> > + __le16 duration;
> > + u8 da[ETH_ALEN];
> > + u8 sa[ETH_ALEN];
> > + u8 bssid[ETH_ALEN];
> > + __le16 seq_ctrl;
> > + u8 addr4[ETH_ALEN];
> > + union {
> > + struct {
> > + __le16 auth_alg;
> > + __le16 auth_transaction;
> > + __le16 status_code;
> > + /* possibly followed by Challenge text */
> > + u8 variable[];
> > + } __packed auth;
> > + struct {
> > + __le16 capab_info;
> > + __le16 listen_interval;
> > + /* followed by SSID and Supported rates */
> > + u8 variable[];
> > + } __packed assoc_req;
> > + } u;
> > +} __pack;
>
> I noticed that you ignored some (all?) of my feedback [1].
>
> Maybe my feedback got lost between the quotes, maybe you just forgot to
> apply it. Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
I think I replied your request and follow it. Please check following link:
https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB9638DEFC074F41AAEE3AC471D1DBA@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
Please press "Series: | expand", you will find cover letter with related patches there. You can review any commit and reply the e-mail separately. Thanks.
> Francesco
>
> [1]
> https://lore.kern/
> el.org%2Fall%2FZRLsuJfxuvFk1K16%40francesco-nb.int.toradex.com%2F&data=
> 05%7C01%7Cyu-hao.lin%40nxp.com%7C60169d7a09b1452f396708dbd24e9e7
> 2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383350073303695
> 20%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=cBRFymTJojjf
> Kp%2F42K%2FWue8ctA1mTdIOqGjtgiHx%2Bsg%3D&reserved=0
