Franky Lin <franky.lin@xxxxxxxxxxxx> writes: > Hi Justin, > > On Mon, Oct 16, 2023 at 3:14 PM Justin Stitt <justinstitt@xxxxxxxxxx> wrote: >> >> strncpy() is deprecated for use on NUL-terminated destination strings >> [1] and as such we should prefer more robust and less ambiguous string >> interfaces. >> >> This patch replaces multiple strncpy uses. For easier reading, I'll list >> each destination buffer and mention whether it requires either >> NUL-termination or NUL-padding. > > Kudos to the detailed analysis of each instance. One thing I can think > of to make this better is to split it into smaller patches so if any > regression is observed, only the specific code causing it needs to be > reverted. Maybe instance 2, 3, 4 can be handled in one patch since > they are touching the country code in one file. The other instances > each can be an individual patch. > > The "brcmfmac" in the title is not accurate. The change touches both > brcmfmac and brcmsmac. So "brcm80211" would be more appropriate. Please also add "wifi:" to the title, see the wiki link below for more info. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
