On Mon, 16 Oct 2023 at 07:35, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 15/10/2023 22:03, Luca Weiss wrote: > > Add a compatible for the iris subnode in the WCNSS PIL. > > > > Signed-off-by: Luca Weiss <luca@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > index 45eb42bd3c2c..0e5e0b7a0610 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml > > @@ -111,6 +111,7 @@ properties: > > - qcom,wcn3660 > > - qcom,wcn3660b > > - qcom,wcn3680 > > + - qcom,wcn3680b > > Looks like this should be made as compatible with qcom,wcn3680 (so with > fallback). Yes, agree, let's do a regular fallback as there is nothing 'b' specific in the driver: `compatible = "qcom,wcn3680b", "qcom,wcn3680";` And yes, we should also have done that for qcom,wcn3660b... Regards, Loic