On Sat, Oct 14, 2023 at 07:21:30AM +0800, Shiji Yang wrote: > 1. Move MT7620 PA/LNA calibration code to dedicated functions. > 2. For external PA/LNA devices, restore RF and BBP registers before > R-Calibration. > 3. Do Rx DCOC calibration again before RXIQ calibration. > 4. Add some missing LNA related registers' initialization. > > Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx> <snip> > int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev) > { > u32 reg; > @@ -10762,6 +10831,10 @@ int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev) > rt2800_init_bbp(rt2x00dev); > rt2800_init_rfcsr(rt2x00dev); > > + /* Do calibration and init PA/LNA for RT6352 */ > + if (rt2x00_rt(rt2x00dev, RT6352)) > + rt2800_calibration_rt6352(rt2x00dev); rt2800_init_rcsr() -> rt2800_init_rfcsr_6352() is called right before this. Could we have rt2800_calibration_rt6352() there ? Regards Stanislaw