> -----Original Message----- > From: Dmitry Antipov <dmantipov@xxxxxxxxx> > Sent: Wednesday, October 11, 2023 11:45 PM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Dmitry Antipov <dmantipov@xxxxxxxxx> > Subject: [PATCH 2/2] wifi: rtlwifi: simplify TX command fill callbacks > > Since 'rtlpriv->cfg->ops->fill_tx_cmddesc()' is always called > with 'firstseg' and 'lastseg' set to 1 (and the latter is The 'firstseg' is used to optimize the code if more than one segments. However, I think rtlwifi will not support multiple segments in the future, so changes in this patch would be fine. > never actually used), all of the relevant chip-specific > routines may be simplified. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>