Lingbo Kong <quic_lingbok@xxxxxxxxxxx> wrote: > Currently, ath12k does not support Time-Average-SAR(TAS) for WCN7850. In > order to enable Time-Average-SAR(TAS) for WCN7850, ath12k defines > ath12k_get_acpi_all_data() function to get TAS configuration and SAR power > table, then sets pdev_id, param_type_id, and finally sends the TAS > configuration, SAR power table and WMI_PDEV_SET_BIOS_INTERFACE_CMDID > command to firmware to implement TAS during the initialization phase. > Besides, ath12k registers an ACPI event callback so that ACPI can notify > ath12k to get the updated SAR power table and sends it to firmware when the > device state is changed. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Lingbo Kong <quic_lingbok@xxxxxxxxxxx> > Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> This adds a lot of new warnings: drivers/net/wireless/ath/ath12k/wmi.c:7172:21: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath12k/wmi.c:7172:21: expected restricted __le32 [usertype] length drivers/net/wireless/ath/ath12k/wmi.c:7172:21: got int drivers/net/wireless/ath/ath12k/acpi.h:27: line length of 96 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:115: line length of 96 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:152: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:154: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:165: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:255: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:257: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:278: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:301: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:309: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:317: line length of 96 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:328: line length of 95 exceeds 90 columns drivers/net/wireless/ath/ath12k/acpi.c:330: line length of 95 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:6995: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7007: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7009: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7035: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7047: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7049: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7070: line length of 97 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7079: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7099: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7101: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7128: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7139: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7141: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7168: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7180: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7182: line length of 94 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7207: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7219: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/wmi.c:7221: line length of 94 exceeds 90 columns Please ALWAYS run ath12k-check. 4 patches set to Changes Requested. 13416565 [v6,1/4] wifi: ath12k: add TAS capability for WCN7850 13416566 [v6,2/4] wifi: ath12k: add BIOS SAR capability for WCN7850 13416564 [v6,3/4] wifi: ath12k: add adjust configuration of CCA threshold value for WCN7850 13416567 [v6,4/4] wifi: ath12k: add set band edge channel power for WCN7850 -- https://patchwork.kernel.org/project/linux-wireless/patch/20231011050004.423413-2-quic_lingbok@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches