Kalle Valo <kvalo@xxxxxxxxxx> writes: > On v6.6-rc4 with GCC 13.2 I see: > > drivers/net/wireless/intel/iwlwifi/dvm/main.c:1467:19: warning: '%s' > directive output may be truncated writing up to 63 bytes into a region > of size 32 [-Wformat-truncation=] > drivers/net/wireless/intel/iwlwifi/dvm/main.c:1465:9: note: 'snprintf' > output between 1 and 64 bytes into a destination of size 32 > drivers/net/wireless/intel/iwlwifi/mvm/ops.c:1307:19: warning: '%s' > directive output may be truncated writing up to 63 bytes into a region > of size 32 [-Wformat-truncation=] > drivers/net/wireless/intel/iwlwifi/mvm/ops.c:1305:9: note: 'snprintf' > output between 1 and 64 bytes into a destination of size 32 > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:549:33: warning: '%s' > directive output may be truncated writing up to 63 bytes into a region > of size between 48 and 56 [-Wformat-truncation=] > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:547:9: note: 'snprintf' > output 9 or more bytes (assuming 80) into a destination of size 64 > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:729:33: warning: '%s' > directive output may be truncated writing up to 63 bytes into a region > of size between 48 and 56 [-Wformat-truncation=] > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:727:9: note: 'snprintf' > output 9 or more bytes (assuming 80) into a destination of size 64 > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:989:51: warning: '%s' > directive output may be truncated writing up to 63 bytes into a region > of size between 46 and 58 [-Wformat-truncation=] > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:987:33: note: 'snprintf' > output between 7 and 82 bytes into a destination of size 64 > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:984:53: warning: '%s' > directive output may be truncated writing up to 63 bytes into a region > of size between 40 and 50 [-Wformat-truncation=] > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:982:33: note: 'snprintf' > output between 15 and 88 bytes into a destination of size 64 > > Two of the warnings were easy to fix by using strscpy(). But the rest were more > challening. For now I was only able to come up with artificial testing of > snprintf() return value but that doesn't make really sense. I marked the ugly > once "FIXME" in the code. > > Any ideas how to fix the warnings properly? > > Compile tested only. > > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxx> I didn't notice that Gregory had already submitted a patch: https://patchwork.kernel.org/project/linux-wireless/patch/20231012153950.f4465b4b4e2b.Idced2e8d63c492872edcde1a3ce2cdd6cc0f8eb7@changeid/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
