On Mon, 2023-10-09 at 17:48 +0200, Johannes Berg wrote: > > On Fri, 2023-10-06 at 21:13 +0800, Ping-Ke Shih wrote: > > https://www.radiotap.org/fields/U-SIG.html defines bandwidth field but > > no enumerators there, so reference to the values defined by wireshark [1]. > > > > [1] > > https://github.com/wireshark/wireshark/blob/master/epan/dissectors/packet-ieee80211-radiotap.c#L2466 > > > > Well. The entries here should be coming from the spec, see Table 36-28 > "U-SIG field of an EHT MU PPDU" in 802.11be (D3.0) (or 36-31, it's the > same since it's U-SIG-1 common part). > > So maybe we should define them in ieee80211.h? > > But at the very least I think the patch description (and perhaps > comments in the code) should reference that, rather than wireshark > sources :) > Thanks. That should be from 802.11be definitely, and I feel these entries in drivers are only used by radiotap (mostly hardware should handle that field), so I decide to keep them in ieee80211_radiotap.h, and only modify commit message. Ping-Ke
